Vita: Fixed absence of clipping when viewport is set #13194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wohlstand
force-pushed
the
fix-vita-viewport
branch
from
43b4d75 to
c433cbf
Compare
|
This fix is much better than the existing behavior, but I think it might not handle the case where a manually-specified clip rect is larger than the viewport. |
A good case, then it's need to cut down the clip rect when viewport is set, and rectangle is out of viewport's range. |
Don't allow cliprect be larger than viewport's scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a problem of viewport on the Vita set by
SDL_RenderSetViewport()that doesn't sets any clipping by default.How it looked before the fix:
How it supposed to look everywhere (after fix):
Description
This solution sets the cliprect in shadow when real cliprect is unused. And when cliprect gets reset, the viewport's rect gets set when viewport is set (the width and height gets compared to the size of the drawable area such as screen or texture).
Existing Issue(s)
#13034