feat: update MSRV to 1.88.0, bump Rust edition to 2024 by ackintosh · Pull Request #6273 · libp2p/rust-libp2p

ackintosh · 2026-02-12T21:10:44Z

Description

This PR bumps the MSRV to 1.88.0 in order to address a vulnerability in the time crate, and the workspace Rust edition to 2024.

Notes & open questions

Also updated the current stable rust version in ci.yml.
The Continuous integration / Compile on x86_64-pc-windows-msvc job failed due to a timeout while setting up the Rust toolchain. We should retry it.

Change checklist

I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
A changelog entry has been made in the appropriate crates

error: manual implementation of `.is_multiple_of()` https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#manual_is_multiple_of

Cargo.toml

This commit bumps the minor version of all crates (except libp2p-identity which maintains its own rust-version) and adds corresponding CHANGELOG entries.

ackintosh · 2026-02-13T22:25:53Z

I've bumped the minor version of all crates, except libp2p-identity, which maintains its own rust-version.

jxs

Thanks for this Akihito! Left a comment wrt libp2p-peer-store. Meanwhile can we also bump the edition to 2024? cc @elenaf9 @dariusc93

examples/stream/Cargo.toml

misc/peer-store/Cargo.toml

elenaf9 · 2026-03-17T08:46:18Z

Meanwhile can we also bump the edition to 2024? cc @elenaf9 @dariusc93

👍 we need the bump for #6260 anyway.

Edit: done with b04e82d.

Cargo.toml

misc/peer-store/Cargo.toml

misc/peer-store/CHANGELOG.md

Co-authored-by: Elena Frank <elena.frank@proton.me>

elenaf9

Revert version bumps where the major version wasn't released yet, merge changelogs.

libp2p/CHANGELOG.md

misc/metrics/CHANGELOG.md

protocols/gossipsub/Cargo.toml

protocols/gossipsub/CHANGELOG.md

protocols/kad/Cargo.toml

transports/webrtc/CHANGELOG.md

transports/websocket/CHANGELOG.md

Cargo.toml

Co-authored-by: Elena Frank <elena.frank@proton.me>

elenaf9 · 2026-03-17T09:36:05Z

Ugh; quite a lot of lints had to be fixed, i assume due to Rust edition 2024. Also quite a huge diff from rust fmt, sorry about that, see 6d407a3.

Edit: split the commit into two to make review easier:

8443dbe fixes clippy lints
a3b04c2 is just formatting

Revert #6330. The rmp-serde bump includes a rust edition bump, so until #6273 is merged it breaks clippy. Pull-Request: #6347.

jxs · 2026-03-17T14:50:40Z

I've bumped the minor version of all crates, except libp2p-identity, which maintains its own rust-version.

Actually, we should consider bumping libp2p-identity as well. We already bump all other crates anyway, so a libp2p-identity bump doesn't change much for us. It would also resolve #6260. Wdyt @jxs?

yeah, since we are on it matter as well do it.
Thanks for jumping in Elena, and helping moving this forward

elenaf9 · 2026-03-19T08:28:24Z

I've bumped the minor version of all crates, except libp2p-identity, which maintains its own rust-version.

Actually, we should consider bumping libp2p-identity as well. We already bump all other crates anyway, so a libp2p-identity bump doesn't change much for us. It would also resolve #6260. Wdyt @jxs?

yeah, since we are on it matter as well do it. Thanks for jumping in Elena, and helping moving this forward

Hmm, so a minor bump in libp2p-identity is a bit more difficult actually, because the multiaddr crates depends on it as well and we'll end up with conflicting versions (the workspace one vs the released on that multiaddr depends on).

I think what we'd need to do is:

bump and release libp2p-identity -> will temporarily break our master
update the libp2p-identity dependency in multiaddr and release multiaddr
update our multiaddr dependency in the workspace -> will resolve version conflicts

Is there an easier way to solve this?

ackintosh · 2026-03-21T23:18:38Z

Thanks @elenaf9, for moving this PR forward. I've been thinking about an easier approach, but couldn't come up with one. I agree with the approach you suggested.

mergify · 2026-03-23T11:10:45Z

This pull request has merge conflicts. Could you please resolve them @ackintosh? 🙏

jxs · 2026-03-23T12:04:46Z

I've bumped the minor version of all crates, except libp2p-identity, which maintains its own rust-version.

Actually, we should consider bumping libp2p-identity as well. We already bump all other crates anyway, so a libp2p-identity bump doesn't change much for us. It would also resolve #6260. Wdyt @jxs?

yeah, since we are on it matter as well do it. Thanks for jumping in Elena, and helping moving this forward

Hmm, so a minor bump in libp2p-identity is a bit more difficult actually, because the multiaddr crates depends on it as well and we'll end up with conflicting versions (the workspace one vs the released on that multiaddr depends on).

I think what we'd need to do is:

bump and release libp2p-identity -> will temporarily break our master

update the libp2p-identity dependency in multiaddr and release multiaddr

update our multiaddr dependency in the workspace -> will resolve version conflicts

Is there an easier way to solve this?

unfortunately no, libp2p-identity and libp2p-core have this problem

# Conflicts: # Cargo.toml # protocols/autonat/CHANGELOG.md # protocols/gossipsub/CHANGELOG.md # protocols/rendezvous/CHANGELOG.md # protocols/request-response/CHANGELOG.md # protocols/request-response/tests/error_reporting.rs # transports/dns/CHANGELOG.md

ackintosh · 2026-03-23T21:47:54Z

I've merged current master to fix the merge conflicts.

mergify · 2026-03-24T22:44:50Z

This pull request has merge conflicts. Could you please resolve them @ackintosh? 🙏

elenaf9 · 2026-03-25T08:08:19Z

I think what we'd need to do is:

bump and release libp2p-identity -> will temporarily break our master

update the libp2p-identity dependency in multiaddr and release multiaddr

update our multiaddr dependency in the workspace -> will resolve version conflicts

Is there an easier way to solve this?

unfortunately no, libp2p-identity and libp2p-core have this problem

I think libp2p-core isn't an issue, because multiaddr doesn't depend on it.

I would propose to handle libp2p-identity in a separate PR. I'd like to think about it some more and we shouldn't block this one on it. Okay @jxs @ackintosh?

# Conflicts: # protocols/gossipsub/CHANGELOG.md

# Conflicts: # Cargo.lock # Cargo.toml # protocols/gossipsub/src/behaviour.rs # protocols/gossipsub/src/behaviour/tests/mod.rs # transports/tls/CHANGELOG.md # transports/tls/Cargo.toml

to fix the clippy error https://github.com/libp2p/rust-libp2p/actions/runs/23620754942/job/68799195890?pr=6273

warning: this `if` statement can be collapsed https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if

ackintosh · 2026-03-26T22:56:09Z

Updated to keep up with the gossipsub partial messages extension and Rust 2024 edition.

https://github.com/libp2p/rust-libp2p/actions/runs/23621890917/job/68802743702?pr=6273

ackintosh · 2026-03-27T23:15:44Z

I think what we'd need to do is:

bump and release libp2p-identity -> will temporarily break our master

update the libp2p-identity dependency in multiaddr and release multiaddr

update our multiaddr dependency in the workspace -> will resolve version conflicts

Is there an easier way to solve this?

unfortunately no, libp2p-identity and libp2p-core have this problem

I think libp2p-core isn't an issue, because multiaddr doesn't depend on it.

I would propose to handle libp2p-identity in a separate PR. I'd like to think about it some more and we shouldn't block this one on it. Okay @jxs @ackintosh?

Looks good to me, thanks @elenaf9!

jxs

LGTM!
Let's merge this, syked to use if let chains and glad clippy updated them

protocols/autonat/src/v2/client/behaviour.rs

protocols/gossipsub/CHANGELOG.md

elenaf9 · 2026-03-31T08:45:40Z

Thanks @ackintosh!

ackintosh added 5 commits February 13, 2026 05:53

chore: update MSRV from 1.83.0 to 1.88.0

53ecf16

Fix clippy errors

f5d4584

error: manual implementation of `.is_multiple_of()` https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#manual_is_multiple_of

Update Rust stable version

8dd06d5

Add CHANGELOG entry

3205190

Update CHANGELOG

a6f2ab8

ackintosh marked this pull request as ready for review February 12, 2026 21:22

elenaf9 reviewed Feb 13, 2026

View reviewed changes

Cargo.toml Show resolved Hide resolved

ackintosh added 3 commits February 14, 2026 06:09

Update Rust version in Dockerfile

fca8552

Bump minor version for all crates due to MSRV change

0c25ffb

This commit bumps the minor version of all crates (except libp2p-identity which maintains its own rust-version) and adds corresponding CHANGELOG entries.

Update workspace dependency versions

e05da86

Merge branch 'master' into bump-msrv

735b234

jxs approved these changes Mar 16, 2026

View reviewed changes

examples/stream/Cargo.toml Show resolved Hide resolved

misc/peer-store/Cargo.toml Outdated Show resolved Hide resolved

Merge branch 'master' into bump-msrv

f6a72a9

elenaf9 reviewed Mar 17, 2026

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

misc/peer-store/Cargo.toml Outdated Show resolved Hide resolved

elenaf9 reviewed Mar 17, 2026

View reviewed changes

misc/peer-store/CHANGELOG.md Outdated Show resolved Hide resolved

elenaf9 added 3 commits March 17, 2026 09:49

chore(peer-store): revert bump

504762d

Co-authored-by: Elena Frank <elena.frank@proton.me>

feat: bump rust edition to 2024

b04e82d

Merge branch 'master' into bump-msrv

2958bba

elenaf9 reviewed Mar 17, 2026

View reviewed changes

chore(*): merge changelog entries, revert unnecessary bumps

7159e0c

Co-authored-by: Elena Frank <elena.frank@proton.me>

elenaf9 changed the title ~~chore: update MSRV~~ feat: update MSRV tp 1.88.0, bump Rust edition to 20204 Mar 17, 2026

elenaf9 added 2 commits March 17, 2026 11:26

chore: clippy fixes for rust edition 2024

8443dbe

chore: rustfmt 2024

a3b04c2

elenaf9 force-pushed the bump-msrv branch from 6d407a3 to a3b04c2 Compare March 17, 2026 10:28

elenaf9 changed the title ~~feat: update MSRV tp 1.88.0, bump Rust edition to 20204~~ feat: update MSRV tp 1.88.0, bump Rust edition to 2024 Mar 17, 2026

elenaf9 changed the title ~~feat: update MSRV tp 1.88.0, bump Rust edition to 2024~~ feat: update MSRV to 1.88.0, bump Rust edition to 2024 Mar 17, 2026

elenaf9 requested a review from jxs March 17, 2026 10:31

mergify bot pushed a commit that referenced this pull request Mar 17, 2026

fix: downgrade rmp-serde 1.3.1 -> 1.3.0

da3df26

Revert #6330. The rmp-serde bump includes a rust edition bump, so until #6273 is merged it breaks clippy. Pull-Request: #6347.

This was referenced Mar 17, 2026

fix(ci): cargo deny failure #6257

Open

feat: bump msrv to 1.85.0 and use 2024 edition #5894

Closed

elenaf9 mentioned this pull request Mar 23, 2026

chore(deps): update dependencies #6355

Draft

4 tasks

ackintosh added 5 commits March 26, 2026 06:57

Merge branch 'master' into bump-msrv

1676e65

# Conflicts: # protocols/gossipsub/CHANGELOG.md

Merge branch 'master' into bump-msrv

a8b15e2

# Conflicts: # Cargo.lock # Cargo.toml # protocols/gossipsub/src/behaviour.rs # protocols/gossipsub/src/behaviour/tests/mod.rs # transports/tls/CHANGELOG.md # transports/tls/Cargo.toml

remove explicit ref binding in implicitly-borrowing pattern

2d06055

to fix the clippy error https://github.com/libp2p/rust-libp2p/actions/runs/23620754942/job/68799195890?pr=6273

fix clippy warnings

35719bd

warning: this `if` statement can be collapsed https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if

cargo fmt

766da38

Fix clippy(beta) warning

99810b1

https://github.com/libp2p/rust-libp2p/actions/runs/23621890917/job/68802743702?pr=6273

ackintosh force-pushed the bump-msrv branch from dc47555 to 99810b1 Compare March 27, 2026 23:09

elenaf9 mentioned this pull request Mar 30, 2026

chore: update rand and make it a workspace dependency #6276

Draft

jxs approved these changes Mar 30, 2026

View reviewed changes

protocols/autonat/src/v2/client/behaviour.rs Show resolved Hide resolved

protocols/gossipsub/CHANGELOG.md Show resolved Hide resolved

Merge branch 'master' into bump-msrv

9e5e19e

elenaf9 added the send-it label Mar 30, 2026

elenaf9 merged commit b6b79b2 into libp2p:master Mar 31, 2026
67 of 70 checks passed

ackintosh deleted the bump-msrv branch March 31, 2026 20:07

ackintosh mentioned this pull request Mar 31, 2026

chore(deps): bump time due to RUSTSEC-2026-0009 #6268

Merged

4 tasks

Conversation

ackintosh commented Feb 12, 2026 • edited by elenaf9 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes & open questions

Change checklist

Uh oh!

Uh oh!

ackintosh commented Feb 13, 2026

Uh oh!

jxs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elenaf9 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elenaf9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elenaf9 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jxs commented Mar 17, 2026

Uh oh!

elenaf9 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ackintosh commented Mar 21, 2026

Uh oh!

mergify bot commented Mar 23, 2026

Uh oh!

jxs commented Mar 23, 2026

Uh oh!

ackintosh commented Mar 23, 2026

Uh oh!

mergify bot commented Mar 24, 2026

Uh oh!

elenaf9 commented Mar 25, 2026

Uh oh!

ackintosh commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ackintosh commented Mar 27, 2026

Uh oh!

jxs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elenaf9 commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ackintosh commented Feb 12, 2026 •

edited by elenaf9

Loading

elenaf9 commented Mar 17, 2026 •

edited

Loading

elenaf9 commented Mar 17, 2026 •

edited

Loading

elenaf9 commented Mar 19, 2026 •

edited

Loading

ackintosh commented Mar 26, 2026 •

edited

Loading