chore(deps): bump rand in identity and core#6092
Closed
hanabi1224 wants to merge 1 commit intolibp2p:masterfrom
Closed
chore(deps): bump rand in identity and core#6092hanabi1224 wants to merge 1 commit intolibp2p:masterfrom
hanabi1224 wants to merge 1 commit intolibp2p:masterfrom
Conversation
drHuangMHT
reviewed
Jul 6, 2025
Contributor
drHuangMHT
left a comment
drHuangMHT
left a comment
There was a problem hiding this comment.
Is there any context for switching to 0.9 of rand?
| hashlink = "0.9.0" | ||
| hickory-proto = { version = "0.25.2", default-features = false } | ||
| hickory-resolver = { version = "0.25.2", default-features = false } | ||
| if-watch = "3.2.1" |
Contributor
There was a problem hiding this comment.
I think it we can modify it in-place without reordering
| prometheus-client = "0.23" | ||
| quick-protobuf-codec = { version = "0.3.1", path = "misc/quick-protobuf-codec" } | ||
| quickcheck = { package = "quickcheck-ext", path = "misc/quickcheck-ext" } | ||
| rand = { version = "0.9", default-features = false } |
Contributor
There was a problem hiding this comment.
Might as well specify the patch version.
| break non_zero_scalar; | ||
| } | ||
| }; | ||
| SecretKey(non_zero_scalar.into()) |
Contributor
There was a problem hiding this comment.
p256(and mostly RustCrypto) hasn't moved to 0.9 of rand so SecretKey(SigningKey::random(&mut rand::thread_rng())) doesn't work anymore. Is there a reason for switching to 0.9 of rand now?
Contributor
Author
|
I'd re-work on this after #6102 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
randtov0.9incoreandidentityNotes & open questions
Change checklist