CurvePolygon PIP: apply to collections and contains, disjoint predicates - #1322
Closed
dbaston wants to merge 3 commits into
Closed
CurvePolygon PIP: apply to collections and contains, disjoint predicates#1322dbaston wants to merge 3 commits into
dbaston wants to merge 3 commits into
Conversation
dbaston
changed the title
grootstebozewolf
left a comment
grootstebozewolf
left a comment
There was a problem hiding this comment.
Reviving a look at this after focusing on the curve ops wave.
Scope looks right for A/P: isAnyPointContained / isEveryPointContained on MultiSurface/MultiPoint, plus PostGIS #5832 intersects pin. Preferable to only special-casing bare CURVEPOLYGON×POINT.
One edge worth a test if not already covered elsewhere: empty MULTIPOINT EMPTY / empty collection vs curved area (contains → true? intersects → false?) so getCoordinate() is never hit on empty.
Otherwise LGTM when rebased on current main if needed — happy to help exercise more PIP vectors (interior/boundary/exterior on compound rings) if useful.
Comment assisted by xAI Grok; human reviewed the diff.
3 tasks
grootstebozewolf
added a commit
to grootstebozewolf/geos
that referenced
this pull request
Aug 10, 2026
Rebase of dbaston#1322 onto current main: - SimplePointInAreaLocator: isAnyPointContained / isEveryPointContained - Geometry: curved contains / intersects / disjoint for A/P (incl. MultiSurface) - CAPI tests: MultiPoint×MultiSurface, PostGIS #5832 - Keep existing automatic-linearization tests (merge conflicts resolved) Additions on the rebase: - Empty point sets: isAny → false, isEvery → true (vacuous); null-safe getCoordinate - Empty MULTIPOINT / POINT EMPTY CAPI tests for contains / intersects / disjoint Co-authored-by: Dan Baston <dbaston@gmail.com> Assisted-by: xAI Grok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.