-
Notifications
You must be signed in to change notification settings - Fork 397
Add grid subdivision / rasterization algorithms #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96f73a4 to
843eb01
Compare
|
This looks very exciting, I'm fine w/ the CAPI and not qualified to judge the implementation. The tests look good, maybe see if any of the codecov suggestions for complete coverage are easy to knock off. |
c2d9c93 to
26b08ae
Compare
|
Still working through a couple of minor issues with this. I think it could go in the beta, I'm not seeing anything I can't resolve before release. |
a19511a to
15a7a71
Compare
43bcd9b to
37fec59
Compare
37fec59 to
d48797a
Compare
It isn't really clear to me where the missing nodes are, but this last sentence is an important nuance indeed... because of this overlay operations should not cause slivers,... so at least for my use cases, it not being a valid coverage is not a problem. |
…area ~= cell area
…hat coverage is valid
6a007a8 to
f9b2389
Compare
61dcc60 to
eee29c9
Compare



As discussed in #967, adds functions for:
(1) subdividing a geometry by a rectangular grid
(2) computing the fraction of each cell in a grid that is covered by a polygon
Performance in the included benchmark is 1-3 orders of magnitude faster than repeated calls to
Geometry::intersectionCode was adapted and pared down from https://github.com/isciences/exactextract