Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

V11 signing#17

Open
liamdennehy wants to merge 42 commits intomasterfrom
v11-signing
Open

V11 signing#17
liamdennehy wants to merge 42 commits intomasterfrom
v11-signing

Conversation

@liamdennehy
Copy link
Copy Markdown
Owner

@liamdennehy liamdennehy commented Aug 19, 2019 •
edited
Loading

Support v11-compliant signing, including:

  • New 'hs2019' algorithm value
  • Support SHA-512 (which is what hs2019 expects under the hood)
  • Mask real key algorithm names when new algorithm names are used
  • More explicit error types
  • Allow contextless creation of Contexts:
    • add keys later (better support for default algorithm)
    • set headers later

@liamdennehy
KeyStore: Add Keys
e864154
@liamdennehy
Context: Permit initialisation with no parameters
5dc798a
@liamdennehy
ContextException
4bfb1b8
@liamdennehy
KeStoreTest: Exception on duplicate entry
b4e097a
@liamdennehy
Algorithm: Uniform handling of hash names and valid values
d699dbc
@liamdennehy
KeyStore: Better handling of empty initialisation, fetch default key
65dedc9
@liamdennehy
ContextTest: Move bad algorithm to own test module
08fedd8
@liamdennehy
Context: Start selecting defaults for algorithm at singer() request
b980e16
@liamdennehy
Algorithm: Uniform handling of hash names and valid values
22fc2b8
@liamdennehy
Algorithms: Handle 'hs2019' correctly
d359c94
@liamdennehy
Context: Handle 'hs2019' algorithm when creating signer
3fb5ae6
@liamdennehy
ContextTest: First 'hs2019' test for siging
3743944
@liamdennehy
HmacAlgorithm: handle 'hs2019'
da09ca9
@liamdennehy
HmacContextTest: Test all algorithm values including 'hs2019'
9fc3010
@liamdennehy
ContextTest: Test mismatched algorithm<->keyType
c2819c0
@liamdennehy
ContextTest: v10 behaviour separate from current
346e369
@liamdennehy
SigningString: Get ready for special headers (created), (expires)
9259ba6
@liamdennehy
phphunit: better construction
b0899c6
@liamdennehy
SignatureDates
6023fc6
@liamdennehy
SignatureDates: Class and helper functions
0cee263
@liamdennehy
HeaderList: Return list of headers
b1951ff
@liamdennehy
Context: (created) as default for 'hs2019' alg, created & expires gen…
12401ab 
…erator
@liamdennehy
HeaderList: Test fetching list
c5e822c
@liamdennehy
Signature: Include SignatureDates
e368324
@liamdennehy
SignatureDates: More Helpers
08cafa9
@liamdennehy
SignatureString: array_map seems fancy, but why? Wrecks readability...
78813e5
@liamdennehy
Context: setHeaders and (expires) as offset from (created)
6e318af
@liamdennehy
Signer: pass signatureDates to SigningString
d11e666
@liamdennehy
SignatureParameters: emit created= and expires= when in headerList
67fe681
@liamdennehy
Context: Test (created), (expires), SigningString
bdb6e6a
@blacktemplar
Copy link
Copy Markdown

blacktemplar commented Apr 6, 2020

Is there something missing in this PR or why not merge?

@liamdennehy
Copy link
Copy Markdown
Owner Author

liamdennehy commented Jul 20, 2020

Is there something missing in this PR or why not merge?

There was a lot of activity around the beginning of this year, and the draft is now abandoned and replaced with a new proposal (but also not clear as a competing proposal exists too).

Are you looking for the original protocol features, or the new documents? e.g. Authorization header is now gone...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liamdennehy @blacktemplar