Skip to content

Conversation

@monica-sekoyan
Copy link

Added LazyIteratorWeightedMultiplexer to support dynamic weighting change with various scheduler types ("linear", "exponential", "cosine")

Signed-off-by: Monica Sekoyan <[email protected]>
@monica-sekoyan monica-sekoyan marked this pull request as draft September 6, 2025 22:14
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Could you add a basic unit test to cover the new method on CutSet?

endpoint_url = os.environ["AIS_ENDPOINT"]
version = parse_version(aistore.__version__)
return aistore.Client(endpoint_url, timeout=(1, 20)), version
return aistore.Client(endpoint_url, timeout=(5,30)), version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you roll back all changes in this file?

)

@classmethod
def schedule_mux(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems duplicated, can we remove?

)

@classmethod
def weighted_mux(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to schedule_mux like it was named above? (I noticed this one has updated and more extensive doc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants