ASR,ST and CS recipies #1307
Open
ASR,ST and CS recipies #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
pzelasko
reviewed
Mar 27, 2024
lhotse/cut/data.py
Outdated
| # Case 3: anything else | ||
| else v | ||
| ) | ||
| ) |
Collaborator
There was a problem hiding this comment.
This code shouldn't be reformatted, it's possible you're using a different version of black. Please revert all formatting changes.
Collaborator
There was a problem hiding this comment.
Also please move global imports of optional dependencies like bs4 to local imports instead, the CI is failing on trying to import them.
Collaborator
There was a problem hiding this comment.
I'll continue to review once this is done (too many changes atm)
Contributor
Author
There was a problem hiding this comment.
Thanks @pzelasko , I have addressed your comments.
pzelasko
reviewed
Apr 9, 2024
| "supervisions": default_collate( | ||
| [ | ||
| { | ||
| "text": supervision.text, |
Collaborator
There was a problem hiding this comment.
maybe we can just add ”language”: supervision.language, in the line below and always return it to get rid of the extra option and code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for: