Typehint session return values and internal functions #664
+47
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this library to be rather useful for newer protocols and I wanted to lend a hand while I wait for things to be done with aiohttp (since I'm a contributor over there). One of which being type hints since type hinting code lowers the chance of the developer screwing up and helps keep things up to date. I would've ran ruff or mypy but I wanted to get permission first before I attempt to do something like that so for now I'll just type hint what I thought was missing from this project.
I also used Pipes instead of Union or Optional since 3.9 has been dropped from this project and it would be a good idea to migrate to this new annotation style in the future.
I marked -> Self as a TODO since I don't know how the maintainers wanted to go about adding that in Otherwise I would suggest wrapping
AsyncSessionandSessionaround a@finalwrapper similar to what is in aiohttp.