Fix Content-Type header update for non-empty data in set_curl_options #658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
data=""ordata=b""was treated as a real request body, causingContent-Type: application/octet-streamto be added. This was inconsistent withdata=None, and it led to overwriting valid user-provided headers.Issue Example
In parameterized request flows:
If
POST_DATA="", the old behavior forced:which overrode user intent and broke GET requests where an empty body is not actually a payload.
Fix
Only apply the default content-type if the string/bytes payload is non-empty:
This restores expected behavior:
data=None→ no content-type addeddata=""→ no content-type addeddata="foobar"→ defaults toapplication/octet-stream(unchanged)