Skip to content

Conversation

@oxixes
Copy link

@oxixes oxixes commented Jun 25, 2025

Proposed changes

The entities node uses a shared buffer when buffering is enabled, which leads to nodes returning entities that were not requested and others not returning when multiple requests are processed at the same time.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update only documentation, not any source code.
  • Maintain repository

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have updated the change log (CHANGELOG.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate) (not needed)
  • Any dependent changes have been merged and published in downstream modules (none)

Further comments

This issue has been detected after using these nodes in a production environment with many requests happening at the same time, which lead to the described problem.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@oxixes
Copy link
Author

oxixes commented Jun 25, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant