Avoid backtracking in setext marker detection - #6
Merged
lepture merged 1 commit intoJul 28, 2026
Conversation
lepture
deleted the
codex/fix-regex-to-avoid-backtracking-vulnerabilities
branch
July 28, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SETEXT_MARKER_REused nested repetition which can exhibit catastrophic backtracking on long near-matches and lead to denial-of-service when processing attacker-controlled input.Description
src/wenmode/renderers/markdown.pyto prevent exponential backtracking.tests/test_renderers.pyto cover spaced and unspaced setext markers and to exercise a long near-match to guard against regex DoS regressions.Testing
PYTHONPATH=src uv run pytest tests/test_renderers.py -qwhich passed (106 passed).PYTHONPATH=src uv run pytest -qwhich passed (2303 passed).uv run ruff check src/wenmode/renderers/markdown.py tests/test_renderers.pywhich reported no issues.PYTHONPATH=src uv run mypywhich completed with no reported problems.Codex Task