remove unnecessary where-clauses #4023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they may cause tachys to break with -Znext-solver
|
@lcnr Love to see the work on the new trait solver and that leptos/tachys is being tested in it! I'm happy to merge and release a new version of tachys to include the changes once the CI passes. I'll ping you here once that's done |
|
@lcnr tachys v0.2.3 has been released with your changes included |
|
Awesome, thank you! If you've got the time, please also cherry-pick this commit on top of the last 0.1 release and do a point release for that one as well. |
gbj
pushed a commit
that referenced
this pull request
Jun 6, 2025
they may cause tachys to break with -Znext-solver (cherry picked from commit f34e3a5)
|
@lcnr I've just released an updated 0.1.9 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncovered during a crater run for
-Znext-solverin rust-lang/rust#133502.These where-clauses cause
tachysto fail with an overflow error when compiling with the next-generation trait solver right now: rust-lang/trait-system-refactor-initiative#89. We're still unsure whether we actually have to break this when stabilizing the new solver, so it may not be an issue in the end. This breakage is a really subtle issue and quite unfortunate.Luckily, this PR should be neutral or even desirable by itself, so I think it's fine to merge it regardless of whether it'll be actually necessary to avoid future breakage.
In case this looks good to you, it would be awesome if you could release this change as a point-release for version 0.2 and maybe even backport it to 0.1. It would really help us with our work on the new trait solver.
🐰