Skip to content

Promisify the method startLoadingScripts #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ module.exports = function (config) {

// list of files / patterns to load in the browser
files: [
'tests.webpack.js'
'tests.webpack.js',
'./node_modules/es6-promise/dist/es6-promise.js'
],

// list of files to exclude
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"babel-preset-react": "^6.1.18",
"babel-preset-stage-0": "^6.1.18",
"chai": "~3.5.0",
"es6-promise": "^4.2.4",
"eslint": "^1.9.0",
"karma": "~0.13.22",
"karma-chai": "~0.1.0",
Expand Down
99 changes: 52 additions & 47 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,49 +2,53 @@ import React, { Component } from 'react'
import PropTypes from 'prop-types'
import hoistStatics from 'hoist-non-react-statics'
import { newScript, series, noop } from './utils'
// const Promise = require('es6-promise').Promise;

const loadedScript = []
const pendingScripts = {}
let failedScript = []

export function startLoadingScripts(scripts, onComplete = noop) {
// sequence load
const loadNewScript = (script) => {
const src = typeof script === 'object' ? script.src : script
if (loadedScript.indexOf(src) < 0) {
return taskComplete => {
const callbacks = pendingScripts[src] || []
callbacks.push(taskComplete)
pendingScripts[src] = callbacks
if (callbacks.length === 1) {
return newScript(script)(err => {
pendingScripts[src].forEach(cb => cb(err, src))
delete pendingScripts[src]
})
}
export function startLoadingScripts(scripts) {
return new Promise ((resolve,reject) => {
// sequence load
const loadNewScript = (script) => {
const src = typeof script === 'object' ? script.src : script
if (loadedScript.indexOf(src) < 0) {
return taskComplete => {
const callbacks = pendingScripts[src] || []
callbacks.push(taskComplete)
pendingScripts[src] = callbacks
if (callbacks.length === 1) {
return newScript(script)(err => {
pendingScripts[src].forEach(cb => cb(err, src))
delete pendingScripts[src]
})
}
}
}
}
}
}
const tasks = scripts.map(src => {
if (Array.isArray(src)) {
return src.map(loadNewScript)
}
else return loadNewScript(src)
})
const tasks = scripts.map(src => {
if (Array.isArray(src)) {
return src.map(loadNewScript)
}
else return loadNewScript(src)
})

series(...tasks)((err, src) => {
if (err) {
failedScript.push(src)
}
else {
if (Array.isArray(src)) {
src.forEach(addCache)
}
else addCache(src)
}
})(err => {
removeFailedScript()
onComplete(err)
series(...tasks)((err, src) => {
if (err) {
failedScript.push(src)
}
else {
if (Array.isArray(src)) {
src.forEach(addCache)
}
else addCache(src)
}
})(err => {
removeFailedScript()
if (err) reject(err)
else resolve()
})
})
}

Expand Down Expand Up @@ -90,18 +94,19 @@ const scriptLoader = (...scripts) => (WrappedComponent) => {

componentDidMount () {
this._isMounted = true;
startLoadingScripts(scripts, err => {
if(this._isMounted) {
this.setState({
isScriptLoaded: true,
isScriptLoadSucceed: !err
}, () => {
if (!err) {
this.props.onScriptLoaded()
startLoadingScripts(scripts).then((result, error) => {
if(this._isMounted) {
this.setState({
isScriptLoaded: true,
isScriptLoadSucceed: !error
}, () => {
if (!error) {
this.props.onScriptLoaded()
}
})
}
})
}
})

})
}

componentWillUnmount () {
Expand Down
1 change: 1 addition & 0 deletions test/index.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const ReactTestUtils = require('react-dom/test-utils')
const React = require('react')
const AsyncScriptLoader = require('../src').default
require('es6-promise').polyfill();

class TestComponent extends React.Component {
render () {
Expand Down