Skip to content

Conversation

@PhiBabin
Copy link
Contributor

This webclient is an useful tool to visualize log from competitions. Unfortunately, RoboCup 2018's logs only record 2014 vision packet.
I add support for 2014 vision packet and I also added a dockerfile to run this client.
It would be great if the client at http://www.roboime.com/ssl-webclient/ was upgraded with these fixes.

@jansegre
Copy link
Member

This looks great and very much appreciated, specially the docker part, since because the project is so stalled the required tools are too outdated to work on current distros.

The team is also considering remaking the tools with simpler and more current tools. But this addition is definitely positive.

I'm just gonna nitpick a little on the trailing whitespace, but eitherway I'll try to test it soon (this weekend maybe).

If you can make a build and a different PR for the gh-pages, we can test it faster, that is also the branch that is served at http://www.roboime.com/ssl-webclient/

@PhiBabin
Copy link
Contributor Author

Is the gh-pages branch the content of the public/ folder after a build?

@jansegre
Copy link
Member

If I recall correctly, yes, pretty much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants