Ensure at least one checkbox is checked in mandatory multiple questions#1
Merged
remi-filament merged 14 commits into16.0-add-website_event_questions_multiplefrom Mar 11, 2025
Conversation
remi-filament
force-pushed
the
16.0-add-website_event_questions_multiple
branch
from
660829c to
54aeed2
Compare
remi-filament
force-pushed
the
16.0-mandatory-multiple-questions
branch
from
84727c1 to
a71efed
Compare
remi-filament
requested changes
Mar 10, 2025
Member
remi-filament
left a comment
remi-filament
left a comment
There was a problem hiding this comment.
Thanks @Hugo-Trentesaux for that work, one comment inline about copied code in JS + you should fix pre-commit (I rebased since at first it failed because of issue with CI deprecated version, but you now have another error coming from your code).
website_event_questions_multiple/static/src/js/form_validation.js
Outdated
Show resolved
Hide resolved
remi-filament
merged commit 9ab5256
into
16.0-add-website_event_questions_multiple
4 checks passed
remi-filament
pushed a commit
that referenced
this pull request
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.