fix cursor offset inside CSS zoom containers, add syncZoom() API and demo#1131
Open
x2605 wants to merge 1 commit intoleeoniya:masterfrom
Open
fix cursor offset inside CSS zoom containers, add syncZoom() API and demo#1131x2605 wants to merge 1 commit intoleeoniya:masterfrom
x2605 wants to merge 1 commit intoleeoniya:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix cursor offset when chart is inside a CSS zoom container
When a parent element has CSS zoom applied (e.g., zoom: 1.5), the cursor crosshair and snap point are offset from the actual mouse position. The offset scales proportionally with the zoom factor.
The root cause is that e.clientX - rect.left gives the offset in zoomed (viewport) pixels, but the overlay element's dimensions are in logical (unzoomed) pixels, so the position mapping is wrong.
The fix divides the offset by the effective CSS zoom, which is computed by walking up the DOM tree and accumulating each ancestor's zoom value. This is recalculated in syncRect(), so it stays in sync on mouseenter, scroll, and resize.
For cases where CSS zoom changes dynamically while the cursor is already over the chart, a new u.syncZoom() method is exposed:
A demo is included at demos/inside-css-zoom.html.
This fix was authored with the help of Claude.