Skip to content

Support for 'include' directives added#28

Open
takeshixx wants to merge 5 commits intolebinh:masterfrom
takeshixx:master
Open

Support for 'include' directives added#28
takeshixx wants to merge 5 commits intolebinh:masterfrom
takeshixx:master

Conversation

@takeshixx
Copy link
Copy Markdown

This update allows ngxtop to parse files that are included in the Nginx config via 'include' directives. Useful for large deployments where each vhost is located in a separate config file like:

include /usr/local/www/conf/*.conf;

@lebinh
Copy link
Copy Markdown
Owner

lebinh commented Apr 1, 2014

Thanks, support for include directive would be very helpful indeed. However I think you missed some complications with current implementation:

  • The included file can have other include directives
  • The include file can be specified as relative path to the main nginx config

@takeshixx
Copy link
Copy Markdown
Author

It was just a quick fix to make ngxtop run on my reverse proxy setup. I'll may fix those two issues in the next few days.

@lostsnow
Copy link
Copy Markdown

+1

@oxr463
Copy link
Copy Markdown

oxr463 commented Apr 12, 2020

Merged: ngxtop@f095603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants