Skip to content

Transform old cron to scheduled cron#19

Merged
dlmsr merged 1 commit intomainfrom
improve/scheduled_task
Mar 2, 2026
Merged

Transform old cron to scheduled cron#19
dlmsr merged 1 commit intomainfrom
improve/scheduled_task

Conversation

@TamaroWalter
Copy link
Copy Markdown
Member

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

An old cron job that needs to be adjusted to the new way of defining cron jobs


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

@TamaroWalter TamaroWalter self-assigned this Feb 12, 2026
@TamaroWalter TamaroWalter requested a review from dlmsr February 12, 2026 14:33
@TamaroWalter TamaroWalter force-pushed the improve/scheduled_task branch 2 times, most recently from 15255dc to afec01f Compare February 12, 2026 16:14
Copy link
Copy Markdown
Member

@dlmsr dlmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TamaroWalter, LGTM just a couple of changes:

Comment thread classes/task/insert_missing_helptable_entries.php Outdated
Comment thread classes/task/insert_missing_helptable_entries.php Outdated
Comment thread classes/task/insert_missing_helptable_entries.php Outdated
Comment thread lang/de/local_lsf_unification.php Outdated
Comment thread lang/en/local_lsf_unification.php Outdated
@TamaroWalter TamaroWalter force-pushed the improve/scheduled_task branch from afec01f to 32e8317 Compare February 27, 2026 22:36
@TamaroWalter TamaroWalter linked an issue Mar 1, 2026 that may be closed by this pull request
@dlmsr dlmsr force-pushed the improve/scheduled_task branch from 32e8317 to f194e5a Compare March 2, 2026 15:08
@dlmsr dlmsr force-pushed the improve/scheduled_task branch from f194e5a to da20db5 Compare March 2, 2026 15:10
@dlmsr dlmsr merged commit da20db5 into main Mar 2, 2026
1 check passed
@dlmsr dlmsr deleted the improve/scheduled_task branch March 2, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn local_lsf_unification_cron into a scheduled task

2 participants