Skip to content

Audiences + Send notifications #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Audiences + Send notifications #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1262e1b
create/edit audience filters for notifications
danielneis Sep 29, 2021
e7d165c
filter display by audience - cohorts, roles and profile fields
danielneis Oct 5, 2021
6dc7f59
add option to send notification (but not send them yet)
danielneis Sep 20, 2021
9b0b0bc
send notifications using ad hoc tasks
danielneis Sep 23, 2021
55088d7
remove unneeded reload and add sendnotifications column on table
danielneis Sep 28, 2021
352f6f9
revert breadcrumb changes
danielneis Sep 28, 2021
f261ade
fix no blockid case
danielneis Sep 29, 2021
222653a
add audiences support when sending notifications
danielneis Oct 6, 2021
ece54f2
roles filter refactor
danielneis Oct 7, 2021
420c135
fix role audience filter
danielneis Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions amd/build/custom.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion amd/build/custom.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions amd/src/custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,17 @@ define(['jquery'], function($) {
i === 'enabled' ||
i === 'global' ||
i === 'dismissible' ||
i === 'aicon'
i === 'aicon' ||
i === 'sendnotifications'
) && data[i] == 1) {
affectelement.prop('checked', true);
} else if (
(i === 'enabled' ||
i === 'global' ||
i === 'dismissible' ||
i === 'aicon') && data[i] == 0) {
i === 'aicon' ||
i === 'sendnotifications'
) && data[i] == 0) {
affectelement.prop('checked', false);
} else {
affectelement.val(data[i]);
Expand Down Expand Up @@ -392,4 +395,4 @@ define(['jquery'], function($) {
});
}
};
});
});
Loading