[hotfix] gdoc upload retries #274
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a variety of changes across multiple files to improve code readability, update dependencies, and enhance functionality. The most significant updates include dependency upgrades in the gemspec, adjustments to array type declarations, and simplifications in conditional logic. Below is a breakdown of the most important changes grouped by theme:
Dependency Updates:
google-apis-drive_v3
andgoogle-apis-script_v1
dependencies inlcms-engine.gemspec
to newer versions (~> 0.63.0
and~> 0.27.0
, respectively). Removed commented-out dependencies forlt-google-api
andlt-lcms
.lt-google-api
andlt-lcms
gems toGemfile
with specific branches for updates.Code Simplification:
expanded? ? true : nil
withexpanded? || nil
inapp/interactors/lcms/engine/explore_curriculum_interactor.rb
.%w
syntax for cleaner array declarations inapp/services/lcms/engine/html_sanitizer.rb
. [1] [2]app/models/lcms/engine/user.rb
to explicitly returnfalse
instead ofnil
.Type Declaration Adjustments:
Array[Type]
declarations to[Type]
for attributes in files likeapp/entities/lcms/engine/external_page.rb
andapp/models/lcms/engine/search/document.rb
. [1] [2]change_log
attribute type inapp/forms/lcms/engine/curriculum_form.rb
to[Hash]
.Code Consistency:
app/helpers/lcms/engine/resource_helper.rb
.app/services/lcms/engine/google/drive_service.rb
.Logging Configuration:
Hashie.logger
initialization inconfig/initializers/elasticsearch.rb
to useFile::NULL
for better compatibility.