Skip to content

[hotfix] gdoc upload retries #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

shlag3n
Copy link
Collaborator

@shlag3n shlag3n commented May 30, 2025

This pull request introduces a variety of changes across multiple files to improve code readability, update dependencies, and enhance functionality. The most significant updates include dependency upgrades in the gemspec, adjustments to array type declarations, and simplifications in conditional logic. Below is a breakdown of the most important changes grouped by theme:

Dependency Updates:

  • Updated google-apis-drive_v3 and google-apis-script_v1 dependencies in lcms-engine.gemspec to newer versions (~> 0.63.0 and ~> 0.27.0, respectively). Removed commented-out dependencies for lt-google-api and lt-lcms.
  • Added lt-google-api and lt-lcms gems to Gemfile with specific branches for updates.

Code Simplification:

  • Simplified conditional checks across multiple files, such as replacing expanded? ? true : nil with expanded? || nil in app/interactors/lcms/engine/explore_curriculum_interactor.rb.
  • Used %w syntax for cleaner array declarations in app/services/lcms/engine/html_sanitizer.rb. [1] [2]
  • Adjusted conditional logic in app/models/lcms/engine/user.rb to explicitly return false instead of nil.

Type Declaration Adjustments:

  • Changed Array[Type] declarations to [Type] for attributes in files like app/entities/lcms/engine/external_page.rb and app/models/lcms/engine/search/document.rb. [1] [2]
  • Updated change_log attribute type in app/forms/lcms/engine/curriculum_form.rb to [Hash].

Code Consistency:

  • Removed unnecessary parentheses in conditional expressions across files, such as in app/helpers/lcms/engine/resource_helper.rb.
  • Adjusted method calls to remove redundant arguments in app/services/lcms/engine/google/drive_service.rb.

Logging Configuration:

  • Updated Hashie.logger initialization in config/initializers/elasticsearch.rb to use File::NULL for better compatibility.

@shlag3n shlag3n force-pushed the hotfix-gdoc-upload-retries branch 2 times, most recently from e723f45 to 3569030 Compare May 30, 2025 16:37
@shlag3n shlag3n requested a review from paranoicsan May 30, 2025 16:48
@shlag3n shlag3n force-pushed the hotfix-gdoc-upload-retries branch from 3569030 to f849a31 Compare May 30, 2025 17:21
@shlag3n shlag3n force-pushed the hotfix-gdoc-upload-retries branch from f849a31 to a4170bf Compare May 30, 2025 17:21
@shlag3n shlag3n force-pushed the hotfix-gdoc-upload-retries branch 8 times, most recently from 6d3644d to c1dc110 Compare June 7, 2025 16:14
@shlag3n shlag3n force-pushed the hotfix-gdoc-upload-retries branch from c1dc110 to a1bbc56 Compare June 10, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant