Skip to content

Use bundler advice for including fonts for mathlive. #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Use bundler advice for including fonts for mathlive. #5196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...curation/frontend/shared/views/TipTapEditor/TipTapEditor/components/math/FormulasMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@

<style scoped>

@import 'mathlive/fonts.css';

.formulas-menu {
position: relative;
max-width: 500px;
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@
"babel-jest": "^29.7.0",
"babel-loader": "^9.2.1",
"circular-dependency-plugin": "^5.2.0",
"copy-webpack-plugin": "^13.0.0",
"css-loader": "7.1.2",
"eslint": "^8.57.0",
"eslint-config-prettier": "^10.0.1",
Expand Down
39 changes: 0 additions & 39 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ const WebpackRTLPlugin = require('kolibri-tools/lib/webpackRtlPlugin');

const { InjectManifest } = require('workbox-webpack-plugin');

const CopyPlugin = require('copy-webpack-plugin');

// Function to detect if running in WSL
function isWSL() {
try {
Expand Down Expand Up @@ -169,14 +167,6 @@ module.exports = (env = {}) => {
new WebpackRTLPlugin({
minify: false,
}),
new CopyPlugin({
patterns: [
{
from: path.resolve(__dirname, 'node_modules/mathlive/fonts'),
to: path.join(bundleOutputDir, 'fonts'),
},
],
}),
new CircularDependencyPlugin({
// exclude detection of files based on a RegExp
exclude: /a\.js|node_modules/,
Expand Down