Feedback utility functions #5088
Conversation
| }, | ||
| submitRejectedRecommendationFeedback() { | ||
| const rejectedEvent = new RecommendationsInteractionEvent({ | ||
| recommendation_event_id: this.recommendationsEvent.id, |
There was a problem hiding this comment.
We are missing contentnode_id, content_id, context and feedback_type field here.
| feedback_type: FeedbackTypeOptions.ignored, | ||
| feedback_reason: '', | ||
| }); | ||
| sendRequest(ignoredEvent); |
There was a problem hiding this comment.
It seems that we are currently sending a separate RecommendationsInteractionFeedback event for each "ignored" node. It might be better to send a single object that contains all the ignored node information, or at least consider batching or debouncing these requests.
Even if a user imports just 2 or 3 nodes on average, we end up generating a large number of these events, since other nodes are marked as ignored for each session.
This may not be something that needs to be addressed in this PR, as it could require some backend changes as well. I'm just thinking out loud here about potential optimizations we could explore.
| <KIconButton | ||
| icon="thumbDown" | ||
| :tooltip="$tr('markNotRelevantTooltip')" | ||
| @click.stop="markNotRelevant" |
There was a problem hiding this comment.
It seems like there is an error stating URL is not defined for the FeedBack Object at RecommendationsInteractionEvent.getUrl while testing the thumbs down button, this is probably due to my last PR setting the value export const RECOMMENDATION_INTERACTION_EVENT_URL = urls['recommendations-interaction']; in feedbackApiUtils.js.
Summary
This pr does the following;
References
#5057
#5058
Reviewer guidance
RecommendationsEventandRecommendationsInteractionEventmodels