Migrate data export alert to KDS #5083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
reviewed
Jun 4, 2025
There was a problem hiding this comment.
Hi @yeshwanth235, nice work here, and all works as expected. Leaving few comments for code.
contentcuration/contentcuration/frontend/settings/pages/Account/index.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/settings/pages/Account/index.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/settings/pages/Account/index.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/settings/pages/__tests__/account.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/settings/pages/__tests__/account.spec.js
Show resolved
Hide resolved
…nto issue-5063
Improve clarity and remove dependencies of tests on wrapper internal implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed Alert Component to KModel
References
Fixes #5063
Reviewer guidance
Export data from setting->account
click Export data button