Adding Google Maps JavaScript API#66
Open
dannyaudi wants to merge 2 commits intolearning-software-engineering:mainfrom
Open
Adding Google Maps JavaScript API#66dannyaudi wants to merge 2 commits intolearning-software-engineering:mainfrom
dannyaudi wants to merge 2 commits intolearning-software-engineering:mainfrom
Conversation
HubertGu
reviewed
Mar 21, 2023
Collaborator
HubertGu
left a comment
HubertGu
left a comment
There was a problem hiding this comment.
Overall great contribution. The tutorial for using Google Maps API is very detailed for beginners to learn. Consider adding links to text for ease of use for the reader, and after resolving the conflict this can be merged.
|
|
||
| https://developers.google.com/maps/documentation/javascript/adding-a-google-map#maps_add_map-javascript | ||
|
|
||
| Note that this guide DOES NOT work for a React website, users working in a react environment must follow the "Embedding a Google Map on a React Website" section. |
Collaborator
There was a problem hiding this comment.
Consider linking "Embedding a Google Map on a React Website" to its corresponding section.
|
|
||
| Users utilizing this package must make sure to run `npm install @react-google-maps/api` or add the package to their dependencies before running the website. | ||
|
|
||
| The individual compenents that the user wishes to use must also be included in the imports at the beginning of whichever files they are used in. A full list of the package components and their properties can be found in the "react-google-maps-api-docs" guide link of this section. For example, a user creating a custom map and adding markers to it would perform the following at the beginning of their JavaScript file: |
Collaborator
There was a problem hiding this comment.
Consider adding a link for the "react-google-maps-api-docs". You can use [text](link) to add a link to the text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.