Bridge Physlib distributions to tempered distributions#1347
Conversation
Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
|
Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally. If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks. If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip. Important: If a reviewer adds an |
jstoobysmith
left a comment
There was a problem hiding this comment.
Looks good for now - I think the key point here is that this only works for complex distributions (as far as I am aware), so we can't utilize Mathlib's distributions fully.
|
@Lemmy00 Just saw this was a draft, won't merge it until you say it is ready |
|
@jstoobysmith Yes, that is my understanding too. This bridge is intentionally only for the complex-linear part of the Physlib distribution API, since Mathlib’s |
This PR adds a small bridge from Physlib's distribution API to Mathlib's
TemperedDistributionAPI.Context from previous PRs:
Added in
Physlib/Mathematics/Distribution/Basic.lean:Distribution.toTemperedDistribution: converts a Physlib distribution to a Mathlib tempered distribution with the pointwise convergence topology.Distribution.toTemperedDistribution_apply: evaluation of this conversion is definitionally the original Physlib distribution action.Distribution.toTemperedDistribution_fourierTransform: the conversion commutes with the Fourier transform.Distribution.toTemperedDistribution_ofFiniteMeasure: the converted Physlib finite-measure distribution agrees with Mathlib'sMeasure.toTemperedDistribution.No definitions or lemmas are removed.
Reviewer map:
D.1. Bridge to Mathlib tempered distributions.E.2, which builds directly on Add distributions associated to finite measures #1333.SchwartzSpace.Fourier/PointwiseConvergenceCLMtoTemperedDistribution.Validation run locally:
lake exe cache getlake build Physlib.Mathematics.Distribution.Basiclake buildlake exe lint_all./scripts/lint-style.shNotes: the full build prints an existing unused-simp warning in
Physlib/Electromagnetism/Kinematics/EMPotential.lean;lake exe lint_allexits successfully while printing existing project-wide advisory style/transitive-import reports outside this PR.