Skip to content

feat: Document succSuccAbove implementation tradeoff #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstoobysmith merged 1 commit into from
Jul 1, 2026
Merged

feat: Document succSuccAbove implementation tradeoff #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Physlib/Relativity/Tensors/Contraction/SuccSuccAbove.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ module

public import Mathlib.Data.Finset.Sort
public import Mathlib.Data.Nat.SuccPred
public import Physlib.Meta.TODO.Basic
/-!

# Defining succSuccAbove
Expand Down Expand Up @@ -42,9 +41,12 @@ variable {n : ℕ} {c : Fin (n + 1 + 1) → C}

-/

TODO "Determine a way to simplify the definition of `succSuccAbove` using
predefined functions from Mathlib, but ensuring tactics such as `decide` still
work."
/-!
The definition below is deliberately explicit. Later lemmas identify it with
`Finset.orderEmbOfFin` and `Finset.orderIsoOfFin`, giving a bridge to the Mathlib
API while keeping this form convenient for computation and goals solved by
`decide`.
-/

/-- The embedding of `Fin n` into `Fin (n + 1 + 1)` which leaves a hole
at `i` and `j`. -/
Expand Down
Loading