Skip to content

feat: Close the smallest pendulum configuration-space sorryful definitions#1327

Open
NicolaBernini wants to merge 2 commits into
leanprover-community:masterfrom
NicolaBernini:feat/close-smallest-pendulum-config-space-sorryful-definitions-30June2026
Open

feat: Close the smallest pendulum configuration-space sorryful definitions#1327
NicolaBernini wants to merge 2 commits into
leanprover-community:masterfrom
NicolaBernini:feat/close-smallest-pendulum-config-space-sorryful-definitions-30June2026

Conversation

@NicolaBernini

Copy link
Copy Markdown
Contributor

Overview

Close the smallest pendulum configuration-space sorryful definitions

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

/-- The horizontal position `x₁` of the support mass. -/
supportPosition : ℝ
/-- The angle `φ` that the string makes with the vertical. -/
angle : ℝ

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would make this [Real.Angle](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/SpecialFunctions/Trigonometric/Angle.html#Real.Angle) rather then Real.

@jstoobysmith jstoobysmith added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 30, 2026
Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants