docs(classical-mechanics): add TODO to split harmonic oscillator solution - #1326
Conversation
|
Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally. If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks. If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip. Important: If a reviewer adds an |
| References for the classical harmonic oscillator include: | ||
| - Landau & Lifshitz, Mechanics, page 58, section 21. | ||
|
|
||
| ## v. TODOs |
There was a problem hiding this comment.
sounds good, ive made the change.
|
-awaiting-author |
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved - will merge when passes CI.
Adds a module-level TODO to
HarmonicOscillator/Solution.leanrecording the intended follow-up split discussed after #1308.The TODO keeps
Solution.leanas the umbrella import and records the proposed organization:Solution.Basicfor trajectory construction and equation-of-motion facts;Solution.Energyfor energy-related lemmas;Solution.InitialDatafor alternative initial-condition parametrizations;Solution.AmplitudePhasefor the amplitude-phase normal form;Solution.SpecialTimesfor velocity-zero times, turning points, and zero crossings;Solution.Periodicityfor period and recurrence facts.This is documentation only; no declarations or proofs are changed.