Skip to content

docs(classical-mechanics): add TODO to split harmonic oscillator solution - #1326

Merged
jstoobysmith merged 2 commits into
leanprover-community:masterfrom
nateabr:harmonic-oscillator-solution-split-todo
Jun 30, 2026
Merged

docs(classical-mechanics): add TODO to split harmonic oscillator solution#1326
jstoobysmith merged 2 commits into
leanprover-community:masterfrom
nateabr:harmonic-oscillator-solution-split-todo

Conversation

@nateabr

@nateabr nateabr commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Adds a module-level TODO to HarmonicOscillator/Solution.lean recording the intended follow-up split discussed after #1308.

The TODO keeps Solution.lean as the umbrella import and records the proposed organization:

  • Solution.Basic for trajectory construction and equation-of-motion facts;
  • Solution.Energy for energy-related lemmas;
  • Solution.InitialData for alternative initial-condition parametrizations;
  • Solution.AmplitudePhase for the amplitude-phase normal form;
  • Solution.SpecialTimes for velocity-zero times, turning points, and zero crossings;
  • Solution.Periodicity for period and recurrence facts.

This is documentation only; no declarations or proofs are changed.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

References for the classical harmonic oscillator include:
- Landau & Lifshitz, Mechanics, page 58, section 21.

## v. TODOs

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove this.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, ive made the change.

@jstoobysmith jstoobysmith added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 30, 2026
@nateabr

nateabr commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Jun 30, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - will merge when passes CI.

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Jun 30, 2026
@jstoobysmith
jstoobysmith merged commit 05930fe into leanprover-community:master Jun 30, 2026
8 checks passed
@nateabr
nateabr deleted the harmonic-oscillator-solution-split-todo branch June 30, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants