Skip to content

Add criticality transfer API to PhyslibAlpha - #1314

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
juanjfndz:codex/cft-alpha-criticality-transfer-api
Jun 29, 2026
Merged

Add criticality transfer API to PhyslibAlpha#1314
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
juanjfndz:codex/cft-alpha-criticality-transfer-api

Conversation

@juanjfndz

Copy link
Copy Markdown
Contributor

This PR adds a small transfer API around IsEulerLagrangeEquivalent and TotalDivergenceEquivalence in the local Classical Field Theory Alpha stack.

It builds directly on #1307 and introduces:

  • IsEulerLagrangeEquivalent.eulerLagrangeOp_eq, exposing the defining equality as a namespaced lemma;
  • IsEulerLagrangeEquivalent.eulerLagrangeOp_eq_zero_iff, transferring Euler--Lagrange vanishing across equivalent lagrangians;
  • directional criticality transfer lemmas from source to target and from target to source;
  • the corresponding convenience wrappers for TotalDivergenceEquivalence.

This PR does not add new mathematical objects or symbolic calculus. It only packages the immediate consequences of the already-approved equivalence predicate, so downstream Alpha files can use named transfer lemmas rather than repeatedly destructing the same iff.

Validation:

  • lake build PhyslibAlpha.ClassicalFieldTheory.Local.TotalDivergenceEquivalence
  • lake build PhyslibAlpha
  • lake exe runPhyslibAlphaLinters
  • ./scripts/PhyslibAlpha/alphaPythonLinters.sh
  • python3 ./scripts/PhyslibAlpha/alphaFileImports.py
  • python3 ./scripts/PhyslibAlpha/noAlphaImports.py

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge now.

@jstoobysmith jstoobysmith added ready-to-merge This PR is approved and will be merged shortly PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. labels Jun 29, 2026
@jstoobysmith
jstoobysmith merged commit 4ae2c71 into leanprover-community:master Jun 29, 2026
7 checks passed
@juanjfndz
juanjfndz deleted the codex/cft-alpha-criticality-transfer-api branch July 1, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants