Skip to content

chore: fix diamonds in cyclotomic extensions - #44057

Open
riccardobrasca wants to merge 3 commits into
leanprover-community:masterfrom
riccardobrasca:RB/Q_alg
Open

riccardobrasca wants to merge 3 commits into
leanprover-community:masterfrom
riccardobrasca:RB/Q_alg

Conversation

@riccardobrasca

Copy link
Copy Markdown
Member

Open in Gitpod

@riccardobrasca riccardobrasca added the WIP Work in progress label Sep 21, 2026
@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

PR summary 540364d453

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ instance : IntCast (CyclotomicField n K)
+ isCyclotomicExtension_of_charZero
- instance [CharZero K] : IsCyclotomicExtension {n} K (CyclotomicField n K)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 540364d).

  • +2 new declarations
  • −1 removed declarations
+CyclotomicField.instIntCast
-CyclotomicField.instIsCyclotomicExtensionSingletonNatSetOfCharZero
+CyclotomicField.isCyclotomicExtension_of_charZero

Decrease in strong tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (strong)
backward.isDefEq.respectTransparency 4351 -1
No changes to weak technical debt.

Current commit 540364d453
Reference commit a8db657b9f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@riccardobrasca riccardobrasca changed the title fix diamond chore: fix diamonds in cyclotomic extensions Sep 22, 2026
@riccardobrasca riccardobrasca removed the WIP Work in progress label Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant