Skip to content

chore(NumberTheory/NumberField/Cyclotomic/Basic): remove all set_options from this file - #44045

Open
Whysoserioushah wants to merge 2 commits into
leanprover-community:masterfrom
Whysoserioushah:edison/remove_setoption
Open

Whysoserioushah wants to merge 2 commits into
leanprover-community:masterfrom
Whysoserioushah:edison/remove_setoption

Conversation

@Whysoserioushah

Copy link
Copy Markdown
Collaborator

Open in Gitpod

@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

PR summary 43eb307fa3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ isIntegral_of_prime_pow.{u_1}
+ mylemma.{u_1}

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 43eb307).

  • +2 new declarations
  • −1 removed declarations
-IsPrimitiveRoot.integralPowerBasis.congr_simp
+IsPrimitiveRoot.isIntegral_of_prime_pow
+IsPrimitiveRoot.mylemma

Decrease in strong tech debt: (relative, absolute) = (6.53, 0.01)
Current number Change Type (strong)
backward.defeqAttrib.useBackward 4142 -1
backward.isDefEq.respectTransparency 4350 -2
backward.isDefEq.respectTransparency.types 2304 -12
No changes to weak technical debt.

Current commit 43eb307fa3
Reference commit 09712d488f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Whysoserioushah Whysoserioushah added WIP Work in progress and removed tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Sep 21, 2026
@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Sep 21, 2026
@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Sep 21, 2026
@riccardobrasca riccardobrasca self-assigned this Sep 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants