Conversation
PR summary 929e884d7aImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| backward.privateInPublic | 520 | 29 |
| adaptation notes | 424 | 29 |
Current commit 929e884d7a
Reference commit 857cdd0aca
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
kim-em
force-pushed
the
pip-autoparam-comments
branch
from
September 21, 2026 10:24
1cc3eea to
4613807
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
#adaptation_noteat eachvariabledeclaration with an autoParam binder whose users needbackward.privateInPublic. These uses (about 80 of the remaining option lines, in 14 files) are not removable on the Mathlib side: the autoParam helper declaration generated for avariableis always private, and any declaration using that variable in a public section silently elaborates tosorrywithout the option. This is leanprover/lean4#14708. The note says whichset_options can go once that is fixed, and stops anyone from spending time on them before then. Each affected file was checked by removing itstrue-only option lines and observing thesorrywarnings and the follow-onautoParam … is not a constanterrors.It also deletes the one option line in
CategoryTheory/SmallObject/Iteration/ExtendToSuccthat turned out to be unnecessary.🤖 Prepared with Claude Code