Conversation
PR summary 2411ae2c1dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| backward.privateInPublic | 477 | -53 |
| backward.privateInPublic.warn | 172 | -43 |
Current commit 2411ae2c1d
Reference commit 0a6c8e0355
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Can you take a look at the test failure, please? |
…number theory by un-privating definitions used in public statements
kim-em
force-pushed
the
pip-unprivate-algebra
branch
from
September 21, 2026 09:05
c1154b2 to
2411ae2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
backward.privateInPublicoption in 9 files across algebra, combinatorics, number theory, order theory and set theory. In each case a private definition appeared in the statement of a public declaration, so it was already part of the public interface in all but name. The fix is to dropprivatefrom those definitions, adding docstrings where they were missing. InAlgebra/EuclideanDomain/Basicthe opposite direction is cleaner: the only consumerxgcdAux_Pbecomes private as well, matching the existing setup inData/Int/GCD. InCombinatorics/SetFamily/FourFunctionsthe definition becomesFinset.collapserather than a root-level name. InCombinatorics/SetFamily/KruskalKatonathe predicate is marked@[expose], since the file'spublic sectionis not exposed and theDecidableRelinstance needs to unfold it.Files where a private lemma appeared in a public statement are handled by wrapping the use site instead, in #44032. Names are kept as they were (for example
Pell.d); suggestions for better names are welcome but are not needed for this PR.🤖 Prepared with Claude Code