Skip to content

feat(Algebra/Group/Subgroup/ZPowers/Lemmas): zmultiples sup/inf over the integers#41261

Open
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/group-theory/zmultiples-int-inf-sup
Open

feat(Algebra/Group/Subgroup/ZPowers/Lemmas): zmultiples sup/inf over the integers#41261
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/group-theory/zmultiples-int-inf-sup

Conversation

@SnirBroshi

Copy link
Copy Markdown
Collaborator

For a b : ℤ:

  • zmultiples a ⊔ zmultiples b = zmultiples (a.gcd b)
  • zmultiples a ⊓ zmultiples b = zmultiples (a.lcm b)

Open in Gitpod

@SnirBroshi SnirBroshi added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 2, 2026
@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR summary af995baae2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ zmultiples_inf
+ zmultiples_sup

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit af995ba).

  • +2 new declarations
  • −0 removed declarations
+Int.zmultiples_inf
+Int.zmultiples_sup

No changes to strong technical debt.

No changes to weak technical debt.

Current commit af995baae2
Reference commit a1566c2f4d

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant