refactor: consolidate linters#1830
Open
fgdorais wants to merge 8 commits into
Open
Conversation
github-actions
Bot
added
the
awaiting-review
fgdorais
force-pushed
the
move-class-linter
branch
from
3f62d1e to
572905e
Compare
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 1, 2026
Contributor
|
Mathlib CI status (docs):
|
Collaborator
|
This seems wrong. This is an environment linter, so belongs in |
Collaborator
Author
|
This was indeed the start of a process to move all (syntax and environment) linters at the same place. The idea is that function takes precedence over implementation. However, I agree, there should be a discussion. |
fgdorais
added
WIP
Contributor
|
Mathlib CI status (docs):
|
fgdorais
force-pushed
the
move-class-linter
branch
3 times, most recently
from
fda8525 to
ad4d752
Compare
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 22, 2026
Contributor
|
Mathlib CI status (docs):
|
fgdorais
force-pushed
the
move-class-linter
branch
from
ad4d752 to
b4961a7
Compare
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 22, 2026
Contributor
|
Mathlib CI status (docs):
|
fgdorais
changed the title
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 24, 2026
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 24, 2026
Contributor
|
Mathlib CI status (docs):
|
Contributor
|
Mathlib CI status (docs):
|
4 tasks
Collaborator
Author
|
awaiting-review |
github-actions
Bot
added
awaiting-review
mathlib-merge-conflicts
Bot
added
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to consolidate all linters in
Batteries.Linters.Previously, environment linters were in
Batteries.Tactic.Lintand only syntax linters were inBatteries.Linters. The distinction is based on implementation instead of function.