-
Notifications
You must be signed in to change notification settings - Fork 42
Feat: Add a Html-highlighted version of #check (grayed-out implicit arguments) #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! I think this command may be a better fit for mathlib. ProofWidgets focuses on general and reusable abstractions for building user interfaces (in particular components that involve TypeScript code so that mathlib can avoid a dependency on NPM), whereas this is more of a specific usecase. |
|
To be honest, I was not really sure where this should belong. I thought it was low-level enough that a potential user might not want Mathlib dependency. Batteries would feel like a natural option if it didn't require ProofWidgets... |
Vtec234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree there is no great place to put this. It only relies on the JSX syntax and HtmlDisplay, so maybe these should eventually be migrated upstream; but in the meantime let's just merge it after all.
Batteries would feel like a natural option if it didn't require ProofWidgets...
Maybe you mean 'did require'?
Co-authored-by: Wojciech Nawrocki <[email protected]>
Co-authored-by: Wojciech Nawrocki <[email protected]>

#checkh nameshows the signature ofnamewith dimmed implicit arguments,#checkh' namealso includes them in the String export.Zulip discussion:
#general > Dimming implicit arguments in `#check`