Skip to content

Conversation

@mirefek
Copy link
Contributor

@mirefek mirefek commented Nov 3, 2025

#checkh name shows the signature of name with dimmed implicit arguments,
#checkh' name also includes them in the String export.
Zulip discussion:
#general > Dimming implicit arguments in `#check`

@mirefek
Copy link
Contributor Author

mirefek commented Nov 3, 2025

screenshot

@mirefek mirefek changed the title Add a Html-highlighted version of #check (grayed-out implicit arguments) Feat: Add a Html-highlighted version of #check (grayed-out implicit arguments) Nov 4, 2025
@Vtec234
Copy link
Collaborator

Vtec234 commented Nov 9, 2025

Hi! I think this command may be a better fit for mathlib. ProofWidgets focuses on general and reusable abstractions for building user interfaces (in particular components that involve TypeScript code so that mathlib can avoid a dependency on NPM), whereas this is more of a specific usecase.

@mirefek
Copy link
Contributor Author

mirefek commented Nov 9, 2025

To be honest, I was not really sure where this should belong. I thought it was low-level enough that a potential user might not want Mathlib dependency. Batteries would feel like a natural option if it didn't require ProofWidgets...
So you would recommend somewhere in Mathlib/Tactics ?

Copy link
Collaborator

@Vtec234 Vtec234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree there is no great place to put this. It only relies on the JSX syntax and HtmlDisplay, so maybe these should eventually be migrated upstream; but in the meantime let's just merge it after all.

Batteries would feel like a natural option if it didn't require ProofWidgets...

Maybe you mean 'did require'?

@mirefek mirefek requested a review from Vtec234 December 6, 2025 21:05
@Vtec234 Vtec234 merged commit 6853e4c into leanprover-community:main Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants