Skip to content

Just some fixes for some minor warnings. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Just some fixes for some minor warnings. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
520e612
Fixing a warning of a missing selector.
jivadevoe May 15, 2013
bf021ae
Fixed a problem where currentIndex is not initialized. This caused a …
jivadevoe May 15, 2013
ff8f651
Fixed a warning about a missing method.
jivadevoe Jun 7, 2013
b292500
Fixing a warning. FYI, arguably, the stuff for Base64 should be a su…
jivadevoe Jun 7, 2013
d4c176d
Fixed 2 deprecation warnings. These calls are now deprecated in iOS 6
jivadevoe Jun 7, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Additions/NSObject+STAdditions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ - (id)performSelectorOnMainThread:(SEL)selector withArguments:(NSArray *)argumen
[invocation setTarget:self];
[invocation retainArguments];

for (int currentIndex; currentIndex < arguments.count; currentIndex++) {
for (int currentIndex = 0; currentIndex < arguments.count; currentIndex++) {
id currentArgument = [arguments objectAtIndex:currentIndex];
[invocation setArgument:&currentArgument atIndex:currentIndex];
}
Expand Down
7 changes: 5 additions & 2 deletions Additions/NSString+STAdditions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
//

#import "STUtils.h"
#include <CommonCrypto/CommonDigest.h>

// Get this from: https://github.com/nicklockwood/Base64.git
#import "Base64.h"

@implementation NSString (STAdditions)

Expand Down Expand Up @@ -271,12 +274,12 @@ - (NSDate *)ISO8601DateValue;

- (CGSize)drawInRect:(CGRect)inRect withFont:(UIFont *)inFont color:(UIColor *)inColor shadowColor:(UIColor *)inShadowColor shadowOffset:(CGSize)inShadowOffset;
{
return [self drawInRect:inRect withFont:inFont lineBreakMode:UILineBreakModeTailTruncation alignment:UITextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset];
return [self drawInRect:inRect withFont:inFont lineBreakMode:NSLineBreakByTruncatingTail alignment:NSTextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset];
}

- (CGSize)drawInRect:(CGRect)inRect withFont:(UIFont *)inFont lineBreakMode:(UILineBreakMode)inLineBreakMode color:(UIColor *)inColor shadowColor:(UIColor *)inShadowColor shadowOffset:(CGSize)inShadowOffset;
{
return [self drawInRect:inRect withFont:inFont lineBreakMode:inLineBreakMode alignment:UITextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset];
return [self drawInRect:inRect withFont:inFont lineBreakMode:inLineBreakMode alignment:NSTextAlignmentLeft color:inColor shadowColor:inShadowColor shadowOffset:inShadowOffset];
}

- (CGSize)drawInRect:(CGRect)inRect withFont:(UIFont *)inFont lineBreakMode:(UILineBreakMode)inLineBreakMode alignment:(UITextAlignment)alignment color:(UIColor *)inColor shadowColor:(UIColor *)inShadowColor shadowOffset:(CGSize)inShadowOffset;
Expand Down
2 changes: 1 addition & 1 deletion iOS/UIKit/STEditableTableViewCell.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ - (id)initWithDelegate:(id)inDelegate;
[label release];

UITextField *entryField = [[UITextField alloc] initWithFrame:CGRectZero];
entryField.textColor = [UIColor tableCellEditableTextColor];
entryField.textColor = [UIColor blackColor];
entryField.contentVerticalAlignment = UIControlContentVerticalAlignmentCenter;
entryField.font = [UIFont systemFontOfSize:16.0];
entryField.delegate = inDelegate;
Expand Down