Skip to content

fix(bench): treat pandas as optional in correctness_precheck #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lavs9 merged 1 commit into from
Jul 16, 2026
Merged

fix(bench): treat pandas as optional in correctness_precheck #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions benchmarks/python_comparisons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ def _library_versions() -> dict[str, str]:
return versions


def _tail_sma_pandas(close: np.ndarray, period: int) -> np.ndarray:
import pandas as pd
def _tail_sma_pandas(close: np.ndarray, period: int) -> np.ndarray | None:
try:
import pandas as pd
except ImportError:
return None

return pd.Series(close).rolling(period).mean().to_numpy()

Expand Down Expand Up @@ -80,12 +83,15 @@ def correctness_precheck(df: pl.DataFrame) -> dict[str, Any]:

checks: dict[str, str] = {}
pd_sma = _tail_sma_pandas(close, SMA_PERIOD)
mask = ~np.isnan(ref) & ~np.isnan(pd_sma)
if mask.any():
ok = np.allclose(ref[mask], pd_sma[mask], rtol=TOLERANCE, atol=TOLERANCE)
checks["pandas_rolling"] = "ok" if ok else "mismatch"
if pd_sma is not None:
mask = ~np.isnan(ref) & ~np.isnan(pd_sma)
if mask.any():
ok = np.allclose(ref[mask], pd_sma[mask], rtol=TOLERANCE, atol=TOLERANCE)
checks["pandas_rolling"] = "ok" if ok else "mismatch"
else:
checks["pandas_rolling"] = "insufficient_warmup"
else:
checks["pandas_rolling"] = "insufficient_warmup"
checks["pandas_rolling"] = "not_installed"

qw = _tail_sma_quantwave(small, SMA_PERIOD)
if qw is not None:
Expand Down
Loading