Skip to content

fix #116 allow backup directory with spaces#118

Open
Wikinaut wants to merge 1 commit into
laurent22:masterfrom
Wikinaut:fix-116--backup-dir-with-spaces
Open

fix #116 allow backup directory with spaces#118
Wikinaut wants to merge 1 commit into
laurent22:masterfrom
Wikinaut:fix-116--backup-dir-with-spaces

Conversation

@Wikinaut

@Wikinaut Wikinaut commented May 9, 2018

Copy link
Copy Markdown
Contributor

@laurent22 here's a formal PR. Attention: I haven't tested it!

@laurent22

laurent22 commented May 17, 2018

Copy link
Copy Markdown
Owner

It seems the pull request sometimes adds two pairs of double quotes, and sometimes one pair of double and one pair single quotes. For example:

"\'$DEST_FOLDER/\'"

"\"$INPROGRESS_FILE\""

That would result in:

"'my/path'"

""my/path""

Is there any reason for this?

Edit: Sorry just saw you haven't tested it, but obviously this needs to be tested as we don't want to break people's backup scripts.

@ventoh

ventoh commented Nov 22, 2018

Copy link
Copy Markdown

+1. For me that has solved the problem. ( directory with spaces in destination backup dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants