fix: Catch all response.shutdown exceptions #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response shutdown might trigger an exception for a number of reasons from within the urllib3 library. Since this is a shutdown procedure, and there isn't a way to recover at that point, we are going to simply catch all possible exceptions and continue to shutdown as gracefully as possible.
jsonbailey
approved these changes
May 29, 2025
keelerm84
pushed a commit
that referenced
this pull request
May 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.4](1.2.3...1.2.4) (2025-05-29) ### Bug Fixes * Catch all response.shutdown exceptions ([#45](#45)) ([cd7262e](cd7262e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response shutdown might trigger an exception for a number of
reasons from within the urllib3 library. Since this is a shutdown
procedure, and there isn't a way to recover at that point, we are going
to simply catch all possible exceptions and continue to shutdown as
gracefully as possible.