Add public pg connect options fields #3983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 3rd party tools can provide a wrapper around this object and can construct the PG options as strict as they want to, while not having to deal with this libraries default behavior at all.
mbj
added a commit
to mbj/mrs
that referenced
this pull request
Aug 20, 2025
* This has to carefully "unset or reject" non bypassable environment variable inference done by `sqlx::postgres::PgConnnectOptions` still its easier to maintain it that way than to maintain the fork. * See: launchbadge/sqlx#3832, launchbadge/sqlx#3983
mbj
added a commit
to mbj/mrs
that referenced
this pull request
Aug 20, 2025
* This has to carefully "unset or reject" non bypassable environment variable inference done by `sqlx::postgres::PgConnnectOptions` still its easier to maintain it that way than to maintain the fork. * See: launchbadge/sqlx#3832, launchbadge/sqlx#3983
|
This is a non-starter unfortunately, because it's a huge backwards-compatibility hazard. It locks us in to this exact representation for all these fields (e.g. preventing changes to I was mostly fine with the changes in #3832, I just disagree that TLS should be required by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a breaking change?
no.
This is an alternative to the issues I raised in #3832, it would enable me to go abitrarily strict in my wrappers and have full control in how I construct
PgConnectOptions.I admit its a bit of an extreme measure, and not as nice for users who go that option but these users would opt into "higher maintenance" burden explicitly, but I see no reason to not give users more sophisticated options than this library is willing to do.