refactor(any): Remove lifetime parameter from AnyArguments #3958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjpotts
force-pushed
the
jp/any-arg-lifetime
branch
2 times, most recently
from
4b8535d to
babd18d
Compare
This was referenced Aug 2, 2025
iamjpotts
force-pushed
the
jp/any-arg-lifetime
branch
2 times, most recently
from
58b46a2 to
3217e7e
Compare
iamjpotts
force-pushed
the
jp/any-arg-lifetime
branch
2 times, most recently
from
b1320b0 to
c8c85e7
Compare
iamjpotts
force-pushed
the
jp/any-arg-lifetime
branch
from
c8c85e7 to
a327b23
Compare
Signed-off-by: Joshua Potts <[email protected]>
iamjpotts
force-pushed
the
jp/any-arg-lifetime
branch
from
a327b23 to
58fdeca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Similar to #3957, allows more flexibility with passing references as bind parameters to
query!macros when using theAnydriver.This is the first of two prs, after which
Query::bindandQuery::try_bindargument lifetimes will be relaxed to be consistent across the drivers. The second pr adds a test which is a compile-time check of the new lifetime allowances for arguments. That test will not compile with just this pr.Second of the two prs:
#3960
Is this a breaking change?
Yes:
AnydriverAnyValueKind