Correctly error on top-level use of \PushDefaultHookLabel{.}#1925
Open
josephwright wants to merge 1 commit intodevelopfrom
Open
Correctly error on top-level use of \PushDefaultHookLabel{.}#1925josephwright wants to merge 1 commit intodevelopfrom
josephwright wants to merge 1 commit intodevelopfrom
Conversation
Comment on lines
+31
to
+41
| ! Use of \??? doesn't match its definition. | ||
| <argument> \??? | ||
| ! LaTeX hooks Error: Empty hook name on line .... | ||
| l. ...\PushDefaultHookLabel{} | ||
| If you say, e.g., `\def\a1{...}', then you must always | ||
| put `1' after `\a', since control sequence names are | ||
| made up of letters only. The macro here has not been | ||
| followed by the required stuff, so I'm ignoring it. | ||
| ! LaTeX hooks Error: You cannot change the default label to 'top-level'. Illegal | ||
| (hooks) \PushDefaultHookLabel{top-level} | ||
| (hooks) on line .... |
Member
There was a problem hiding this comment.
Sorry, but I don't see that this gives any improvement as far as the error message is concerned and not sure what it does from a code perspective. Maybe it would be better to just not support the dot syntax here? @davidcarlisle any thoughts?
|
This PR has been automatically marked as stale because it has not had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated