Merged
Conversation
muzimuzhi
force-pushed
the
align-SHOWPDFTAGS-markers
branch
from
3d5782e to
0f4da13
Compare
Member
|
see what @josephwright says but I'd have thought the changelog entry was enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with the markers used by
\SHOWFILE-------- #1 (start) --------- -------- #1 (end) -----------% <<< two extra "-" at the endThis IS a breaking change. But considering that the
\SHOWPDFTAGSis newly introduced and have limited usages for now (not all LaTeX + l3build repos test on tagged PDFs), do we need an entry in the "Breaking changes" doc section?