Open
Conversation
https://github.com/latex3/l3build/blob/0e64fef4ac5aa093f43c4fdf6403a04abeff44e1/l3build-upload.lua#L185 shell() get incorrect ctan_post sh: line 2: form-string=announcement=XXXXXXXXXXXXX: command not found
Author
|
anyone to review it? @josephwright |
Member
|
Well it looks OK to me but the upload stuff is more @davidcarlisle |
Member
|
@Freed-Wu it would have helped if you had opened an issue with a test case rather than just a PR with no comments on the actual change. You say that you get a shell error (not impossible but an example would help review) then this PR re-orders some code sections. In which cases does this produce different results than the current code. |
Author
|
I try to upload a new project to ctan and meet the shell error. I find it is because incorrect ctan_post be executated as shell and fix it. now it work for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
l3build/l3build-upload.lua
Line 185 in 0e64fef
shell() get incorrect ctan_post
sh: line 2: form-string=announcement=XXXXXXXXXXXXX: command not found