simplify patches for pgf/tikz

[Udi-Fogiel]

Definitely needs some testing, but I think this simplification is worth it (if it works). If it works, in the long run maybe it could go to pgf, as this only sets the direction of two boxes explicitly to LTR, and restore directions in \pgfinterruptpicture (these directions could be saved before the picture).

[jbezos]

I’ve run some tests and, sadly, this patch breaks them.

[Udi-Fogiel]

Can you provide and example?

[jbezos]

@Udi-Fogiel After reading your code, I realized you are assuming \bbl@thetextdir takes only 2 values: 0 for LTR and 1 for RTL. In fact, it takes 3 values, which are the Unicode directions l (0), r (1) and al (2). Perhaps by fixing this, it will work.

[Udi-Fogiel]

@Udi-Fogiel After reading your code, I realized you are assuming \bbl@thetextdir takes only 2 values: 0 for LTR and 1 for RTL. In fact, it takes 3 values, which are the Unicode directions l (0), r (1) and al (2). Perhaps by fixing this, it will work.

Oh, so should the \ifcase code used in other places be used here as well? I see.. Do you want me to push a commit or can you test on your local setup?

[jbezos]

I'll do some tests myself.