Skip to content

Conversation

@fitzsim
Copy link
Contributor

@fitzsim fitzsim commented Oct 30, 2025

Description

Add more OpenJDK tests and make security provider logging less verbose.

Checklist

  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Rustdoc string were added or updated
  • CHANGELOG and/or other documentation added or updated
  • This is not a code change

Reviewer's checklist:

  • Any issues marked for closing are fully addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • A changelog entry is added if the change is significant
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible text
  • Doc string are properly updated

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5
Copy link
Member

simo5 commented Oct 31, 2025

Can you change the PBE test use Sha256 instead of sha1?
Also on failure it may be nice to collect some logging data, you should be able to build kryoptic with the log crate and make it spit out stuff to stderr (assuming that will not create issues for the test execution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants