Updated hydro array copy_to_host function to fix off-by-one copy error#111
Merged
SVLuedtke-LANL merged 1 commit intolanl:develfrom Feb 5, 2026
Merged
Updated hydro array copy_to_host function to fix off-by-one copy error#111SVLuedtke-LANL merged 1 commit intolanl:develfrom
SVLuedtke-LANL merged 1 commit intolanl:develfrom
Conversation
SVLuedtke-LANL
approved these changes
Feb 5, 2026
Collaborator
SVLuedtke-LANL
left a comment
SVLuedtke-LANL
left a comment
There was a problem hiding this comment.
Looks good, passes all my checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an off-by-one error present in the Hydro Array's copy_to_host function. This error was causing exactly one cell of hydro data to not be correctly copied, which was causing the opposite cells data to not be computed correctly during data export.