Skip to content

Conversation

@mnasrautinno
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Context: Agent node supported citations and attributions with this PR #18558 but during the refactoring and decoupling of nodes and node data PR #22581, the logic to emit retriever resource event was removed by an oversight.
Solution: Added the retriever resource transform logic in the agent node

Screenshots

Before After
Before After

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 12, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mnasrautinno, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a regression in the agent node's functionality, specifically restoring the ability to emit retriever resource events. This ensures that citations and attributions, which were previously supported, are correctly processed and made available, rectifying an accidental removal during a recent refactoring effort. The change ensures the agent node properly communicates resource information.

Highlights

  • Restored Retriever Resource Event Emission: Re-implemented the logic within the agent node to emit RunRetrieverResourceEvent for RETRIEVER_RESOURCES message types, addressing an oversight from a previous refactoring that inadvertently removed this functionality.
  • Enhanced Agent Node Data Transformation: The _transform_message function in the agent node now correctly handles and processes retriever resource messages, ensuring that relevant citation and attribution data is properly transformed and emitted as events.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the 🤖 feat:agent Agent related topics label Nov 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where citations and attributions were not functioning correctly in the agent node. The issue stemmed from the accidental removal of logic to emit a retriever resource event during a previous refactoring. The solution reintroduces this logic, ensuring that RETRIEVER_RESOURCES messages are properly handled and the corresponding event is yielded. The fix is correct and well-implemented, though I've pointed out a minor formatting issue.

@autofix-ci
Copy link
Contributor

autofix-ci bot commented Nov 12, 2025

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

mnasrautinno and others added 2 commits November 13, 2025 15:54
Remove white space

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 feat:agent Agent related topics size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant