-
Notifications
You must be signed in to change notification settings - Fork 18.5k
fix: workflow agent node citations and attributions #28138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: workflow agent node citations and attributions #28138
Conversation
Summary of ChangesHello @mnasrautinno, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a regression in the agent node's functionality, specifically restoring the ability to emit retriever resource events. This ensures that citations and attributions, which were previously supported, are correctly processed and made available, rectifying an accidental removal during a recent refactoring effort. The change ensures the agent node properly communicates resource information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug where citations and attributions were not functioning correctly in the agent node. The issue stemmed from the accidental removal of logic to emit a retriever resource event during a previous refactoring. The solution reintroduces this logic, ensuring that RETRIEVER_RESOURCES messages are properly handled and the corresponding event is yielded. The fix is correct and well-implemented, though I've pointed out a minor formatting issue.
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
Remove white space Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Important
Fixes #<issue number>.Summary
Context: Agent node supported citations and attributions with this PR #18558 but during the refactoring and decoupling of nodes and node data PR #22581, the logic to emit retriever resource event was removed by an oversight.
Solution: Added the retriever resource transform logic in the agent node
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods